Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node20 #176

Merged
merged 4 commits into from Feb 15, 2024
Merged

Use node20 #176

merged 4 commits into from Feb 15, 2024

Conversation

parkerbxyz
Copy link
Contributor

@parkerbxyz parkerbxyz commented Feb 9, 2024

This pull request primarily focuses on upgrading the Node.js version used across different parts of the codebase to version 20. The changes affect the continuous integration pipeline, the action configuration, and the development dependencies.

Node.js version upgrade:

  • action.yml: The Node.js version used in the action configuration has been updated from node16 to node20. This change will affect the environment in which the GitHub action runs.
  • .github/workflows/ci.yml: The Node.js version used in the continuous integration pipeline has been updated from 18.x to 20.x. This change will affect the environment in which the CI jobs are run.
  • package.json: The Node.js version specified in the development dependencies has been updated from @tsconfig/node12 to @tsconfig/node20. This change will affect the environment in which the development and testing tasks are run.

This will resolve #175 and the following warning that is currently produced when this action is used in a workflow:

Warning

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: e27dddc. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

An upstream bug is preventing us from using @tsconfig/node-lts, so we'll use @tsconfig/recommended for now.
Copy link
Owner

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parkerbxyz! You're the best ✨

@JasonEtco JasonEtco merged commit 56fdd2d into JasonEtco:main Feb 15, 2024
3 checks passed
@parkerbxyz parkerbxyz deleted the node20 branch February 15, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Node 16 to Node 20
2 participants