Skip to content

Commit

Permalink
fix(shared-docs): display DP/Deprecated tag (angular#1798)
Browse files Browse the repository at this point in the history
PR Close angular#1798
  • Loading branch information
JeanMeche authored and josephperrott committed Feb 21, 2024
1 parent 4abf37a commit b6876b1
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 14 deletions.
2 changes: 2 additions & 0 deletions bazel/api-gen/rendering/entities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ export interface DocEntry {
description: string;
rawComment: string;
jsdocTags: JsDocTagEntry[];
isDeprecated: boolean;
isDeveloperPreview: boolean;
}

/** Documentation entity for a constant. */
Expand Down
41 changes: 27 additions & 14 deletions bazel/api-gen/rendering/templates/header-api.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
* found in the LICENSE file at https://angular.io/license
*/

import { h } from 'preact';
import { EntryType } from '../entities';
import { DocEntryRenderable } from '../entities/renderables';
import {h} from 'preact';
import {EntryType} from '../entities';
import {DocEntryRenderable} from '../entities/renderables';
import {
HEADER_CLASS_NAME,
HEADER_ENTRY_CATEGORY,
HEADER_ENTRY_LABEL,
HEADER_ENTRY_TITLE
HEADER_ENTRY_TITLE,
} from '../styling/css-classes';
import { DocsPillRow } from './docs-pill-row';
import {DocsPillRow} from './docs-pill-row';

/** Component to render a header of the API page. */
export function HeaderApi(props: {entry: DocEntryRenderable}) {
Expand All @@ -28,19 +28,32 @@ export function HeaderApi(props: {entry: DocEntryRenderable}) {
<div className={HEADER_ENTRY_TITLE}>
<div>
<h1>{entry.name}</h1>
<div className={HEADER_ENTRY_LABEL} data-mode={"full"} data-type={entry.entryType.toLowerCase()}>{getEntryTypeDisplayName(entry.entryType)}</div>
if(entry.isDeprecated) {
<div className={HEADER_ENTRY_LABEL} data-mode={"full"} data-type="deprecated">Deprecated</div>
}
if(entry.isDeveloperPreview) {
<div className={HEADER_ENTRY_LABEL} data-mode={"full"} data-type="developer_preview">Developer preview</div>
}
<div
className={HEADER_ENTRY_LABEL}
data-mode={'full'}
data-type={entry.entryType.toLowerCase()}
>
{getEntryTypeDisplayName(entry.entryType)}
</div>
{entry.isDeprecated && (
<div className={HEADER_ENTRY_LABEL} data-mode={'full'} data-type="deprecated">
Deprecated
</div>
)}
{entry.isDeveloperPreview && (
<div className={HEADER_ENTRY_LABEL} data-mode={'full'} data-type="developer_preview">
Developer preview
</div>
)}
</div>
</div>

<p className={'docs-reference-description'} dangerouslySetInnerHTML={({__html: entry.shortHtmlDescription})}></p>
<p
className={'docs-reference-description'}
dangerouslySetInnerHTML={{__html: entry.shortHtmlDescription}}
></p>

<DocsPillRow links={entry.additionalLinks}/>
<DocsPillRow links={entry.additionalLinks} />
</header>
);
}
Expand Down

0 comments on commit b6876b1

Please sign in to comment.