Support default export and UMD #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s possible to support both a CJS export and a `.default` property by
defining the export as an interface that has a call expression and a
default property. This makes it possible to use
`import classNames from 'classnames'` or `classNames.default('')`.
Also this packages exposes a UMD module, meaning `classNames` is
available as a global when using a TypeScript script, but not when using
a TypeScript module. This is supported by adding
`export as namespace classNames`.
remcohaszing
force-pushed
the
fix-types-umd-default
branch
from
5c3853e
to
aa1a0fa
Compare
|
Thanks @remcohaszing 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s possible to support both a CJS export and a
.defaultproperty by defining the export as an interface that has a call expression and a default property. This makes it possible to useimport classNames from 'classnames'orclassNames.default('').Also this packages exposes a UMD module, meaning
classNamesis available as a global when using a TypeScript script, but not when using a TypeScript module. This is supported by addingexport as namespace classNames.Technically this also declares it’s valid to use
classNames.defaultwhen usingclassNamesas a global. It may be better to move the lineclassNames.default = classNamesoutside of the if-statement at runtime.