Use string concatenation to increase performance #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the logic that holds class names in an array and joins them together in the end with direct string concatenation, this results in ~30% performance increase across the board. The following benchmarks were ran on my 2021 MacBook Pro 14-inch with an M1 Pro chip running macOS Sonoma (14.2.1):
Node.js (v21.5.0)
Benchmarking 'strings'.
Benchmarking 'object'.
Benchmarking 'strings, object'.
Benchmarking 'mix'.
Benchmarking 'arrays'.
Firefox (v121.0)
Benchmarking 'strings'.
Benchmarking 'object'.
Benchmarking 'strings, object'.
Benchmarking 'mix'.
Benchmarking 'arrays'.
Chrome (v20.0.6099.129)
Benchmarking 'strings'.
Benchmarking 'object'.
Benchmarking 'strings, object'.
Benchmarking 'mix'.
Benchmarking 'arrays'.
Safari (v17.2.1)
Benchmarking 'strings'.
Benchmarking 'object'.
Benchmarking 'strings, object'.
Benchmarking 'mix'.
Benchmarking 'arrays'.