Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports field to package #342

Merged
merged 1 commit into from Dec 27, 2023
Merged

Add exports field to package #342

merged 1 commit into from Dec 27, 2023

Conversation

jonkoops
Copy link
Collaborator

Adds the exports field to the package, which will explicitly define the exported surface of the library. Closes #321.

"author": "Jed Watson",
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/JedWatson/classnames.git"
},
"type": "commonjs",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this explicit type field as well, which will help eliminate guesswork in future Node.js versions.

@jonkoops jonkoops merged commit 8a840ea into main Dec 27, 2023
5 checks passed
@dcousens dcousens deleted the package-exports branch December 28, 2023 00:14
@dcousens
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we add exports field for this package?
2 participants