Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarks from workspace #350

Merged
merged 1 commit into from Dec 29, 2023
Merged

Remove benchmarks from workspace #350

merged 1 commit into from Dec 29, 2023

Conversation

jonkoops
Copy link
Collaborator

@jonkoops jonkoops commented Dec 29, 2023

Publishing the package with the workpaces field causes issues in legacy Yarn (see #329 (comment)), removing the field and moving all the benchmark dependencies into the root should fix this issue.

@jonkoops jonkoops added the bug label Dec 29, 2023
@jonkoops jonkoops merged commit 9331401 into main Dec 29, 2023
5 checks passed
@jonkoops jonkoops deleted the remove-workspaces branch December 29, 2023 12:42
@dcousens
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants