Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs-missing-explicitState-added #8108

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pmario
Copy link
Contributor

@pmario pmario commented Mar 26, 2024

This PR will allow us to "copy / paste" tabs macro definitions into new tiddlers, without the need to adjust the "explicitState" parameter in the macro.

  • It will be used from the tiddler field.
  • Since it is a field it can be dynamically changed by user code or 3rd party plugins.
  • It will also allow us to read the "needed" state from fields instead using regexps to read it from the macro parameter

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Apr 21, 2024 2:00pm

@Jermolene
Copy link
Owner

That's a great idea, thanks @pmario

@pmario
Copy link
Contributor Author

pmario commented Apr 21, 2024

@Jermolene -- Improved readability and did some more testing. Is ready to be reviewed now

@pmario pmario marked this pull request as draft April 21, 2024 13:47
@pmario
Copy link
Contributor Author

pmario commented Apr 21, 2024

uups forgot the tw function prefix tf. ... switched it draft again

@pmario pmario marked this pull request as ready for review April 21, 2024 13:57
@pmario
Copy link
Contributor Author

pmario commented Apr 21, 2024

@Jermolene -- once Vercel built the preview it should be ready for review

@pmario pmario changed the title tabs-missing-explicitState-added-wip tabs-missing-explicitState-added Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants