Root stylesheet refresh - Stylesheets in single <style> tags
#8130
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
core/modules/startup/render.js
Outdated
| $tw.styleElement.innerHTML = $tw.styleWidgetNode.assignedStyles; | ||
| document.head.insertBefore($tw.styleElement,document.head.firstChild); | ||
|
|
||
| var styleParser = $tw.wiki.parseTiddler("$:/core/ui/RootStylesheet",{parseAsInline: true}), |
There was a problem hiding this comment.
IMO $:/core/ui/RootStylesheet should also be added as a constant at the beginning of the code. see: PAGE_STYLESHEET_TITLE but it should be named PAGE_STYLESHEET_ROOT now
There was a problem hiding this comment.
Yes you're right, I forgot to change that. Good thinking about the new name
There was a problem hiding this comment.
Hi @pmario - I wasn't sure about how to name the constant, so I left PAGE_STYLESHEET_TITLE untouched and added ROOT_STYLESHEET_TITLE and use that title
| @@ -1,5 +1,7 @@ | |||
| title: $:/themes/tiddlywiki/vanilla/reset | |||
| type: text/css | |||
| tags: $:/tags/Stylesheet $:/tags/Stylesheet/Static | |||
| list-before: $:/themes/tiddlywiki/vanilla/base | |||
There was a problem hiding this comment.
hmmm, IMO that's not possible. If a user modifies the sort order by hand this shadow tiddler is converted to a system-tiddler and the list-before field is removed. -> That can lead to future problems for the user, if we change the reset.css again, because it is no shadow anymore
We will probably need to rename the tiddler to $:/themes/tiddlywiki/vanilla/_reset, so it will be automatically listed in front.
@Jermolene -- The problem is, that renaming is not 100% backwards compatible
|
This PR now uses the |
This PR is a follow-up to #8106 , #8118 and #8125
It's also related to the discussion #8128
This puts every tiddler tagged
$:/tags/Stylesheetinto its own<style>tag at theBOTTOMof the<head>section.Why at the bottom? The
listwidget in$:/core/ui/RootStylesheethandles inserting and removing its list items all by itself. It does so by appending at the end of the<head>section. That's why from the beginning inrender.jsandwindows.jsI render thestyleWidgetNodeinto the end of the<head>section and let thelistwidget do its "natural" flow.This uses a modified
viewwidget that's included in this PR. I'm not sure if I got @Jermolene right how it should be done but that's my try on it. It updates thetextContentof its generateddomNodein case the format isplainwikified,htmlwikifiedorhtmlencodedplainwikifiedand the content changes, through a contained macro for example that changes.The
$:/core/ui/RootStylesheetdistinguishes between standard Stylesheet tiddlers and Stylesheet tiddlers tagged$:/tags/Stylesheet/Static. In the latter case they are rendered as text and not refreshed which (I hope) makes it possible to save refresh time if we put static content into static Stylesheet tiddlers.I open this as a draft PR since it has Performance Instrumentation enabled and the code might change based on the feedback I get.