Add defaultHeaders flag that controls helpful default heders that can sometimes interfere with apis #8152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sometimes interfere with apis
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mklauber
commented
Apr 16, 2024
| @@ -19,6 +19,7 @@ The following parameters are used: | |||
| |method |HTTP method (eg "GET", "POST") | | |||
| |body |String data to be sent with the request | | |||
| |binary |<<.from-version "5.3.1">> Set to "yes" to cause the response body to be treated as binary data and returned in base64 format | | |||
| |defaultHeaders |<<.from-version "5.3.4">> Defaults to true. Set to "false" to prevent default headers from being added. This can be helpful when dealing with apis that restrict header fields. | | |||
There was a problem hiding this comment.
I put in the <<.from-version "5.3.4">> as a rough guess. Let me know if it needs to change.
|
Thanks @mklauber and apologies for the delay. |
|
Hi @mklauber I've reverted this PR because of an error reported by @pmario – the client-server edition fails to start. As well as fixing the problem, I think it would be better to rename the parameter/variable to "useDefaultHeaders". |
|
Understood. I'll look into that error, and also update that variable. |
|
New PR up here. #8225 |
|
Thanks @mklauber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraneous headers can interfere with CORS validation when hitting external APIs, due to tightly configured
Access-Control-Allow-Headersheaders. Add a way to disable these headers when they are causing issues.