Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default layout to "Standard Layout" #8172

Merged
merged 3 commits into from
May 29, 2024

Conversation

linonetwo
Copy link
Contributor

@linonetwo linonetwo commented Apr 29, 2024

https://talk.tiddlywiki.org/t/what-is-the-name-of-default-layout-is-it-story-river/9296/2

Only change filename and translation, and $:/core/images/default-layout which is not yet released.

$:/core/ui/PageTemplate is untouched, it will influence too many things. This could be a todo for large version bump.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Apr 29, 2024 9:09am

@linonetwo
Copy link
Contributor Author

linonetwo commented Apr 29, 2024

@BramChen Note that ~Tiddlywiki is translated to 太微 which is simillar to pronouncation in Chinese Mandarin. I may apply this change to other zh-Hans translations in the future. But I'm not sure if this pronouncation also apply to Hong Kong Cantonese and Taiwan Hokkien, so I'm not gonna modify it. I will only modify zh-Hans in this case.

@saqimtiaz
Copy link
Contributor

@linonetwo thank you, I agree that renaming the "default layout" to "standard layout" would be helpful. However, renaming the images is problematic as it can break user code where the old tiddler titles are used. Could you please modify the PR to only change the layout name?

@linonetwo
Copy link
Contributor Author

@saqimtiaz That image was added during this prerelase, so won't break anything other than my plugins (I push the #8020 so I'm using it immediately), and I will update my plugins.

@saqimtiaz
Copy link
Contributor

Thank you @linonetwo.

@Jermolene this looks good to be merged.

@Jermolene
Copy link
Owner

Great thanks @linonetwo @saqimtiaz

@Jermolene Jermolene merged commit 3af2a0a into Jermolene:master May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants