Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Quotes - fix parsing error with spaces before reEndString #8186

Merged
merged 7 commits into from
May 15, 2024

Conversation

joshuafontany
Copy link
Contributor

  • Fixes parsing error when spaces/tabs appear before the end <<<+
  • Clarifies docs as to what to do to "return to block parsing mode" after paragraphs inside block quotes.
  • Clarifies similar docs in the "Hard Line Breaks" (tested inside of a block quote).
  • Additional "Advanced Wikitest and Block Quotes" examples.

Fixes bug: #8183

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview May 12, 2024 1:36am

<<<<

<<<
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should not be removed. Just remove the indentation, then it should work, if copy/pasted to a tiddler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmario. @Jermolene Now that I have identified the bug as parsing tabs/whitespace & clarified the docs, should we keep or remove the example in the parser?

@Jermolene
Copy link
Owner

Thanks @joshuafontany looks good

@Jermolene Jermolene merged commit f129912 into Jermolene:master May 15, 2024
4 checks passed
@joshuafontany joshuafontany deleted the fix-quoteblocks branch May 15, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants