Improvements around JNA and build isolation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Specify idea.config.path and idea.system.path for generation.
If left unspecified, `<generate>` task will write under MPS home and
this can be problematic in case of multiple builds running from the
same MPS home in parallel.
* Add an Ant property for the JNA path so that it can be easily
overridden.
When running tests from the generic distribution the path has to be
overridden to point to the platform-specific subdirectory. However, it
was previously hardcoded to `${artifacts.mps}/lib/jna` and impossible
to override.
|
This solves MPS-36590 and should also help with local MPS-extensions build on macOS. Currently MPS-extensions tests fail on macOS and complain about being unable to load the JNA library. |
sergej-koscejev
added a commit
to JetBrains/MPS-extensions
that referenced
this pull request
Jan 28, 2024
Necessary to run tests on macOS until JetBrains/MPS#71 is fixed
sergej-koscejev
added a commit
to JetBrains/MPS-extensions
that referenced
this pull request
Jan 28, 2024
Necessary to run tests on macOS until JetBrains/MPS#71 is fixed
sergej-koscejev
added a commit
to mbeddr/mps-qa
that referenced
this pull request
Feb 7, 2024
This fixes the build on macOS until JetBrains/MPS#71 is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify
idea.config.pathandidea.system.pathfor generation.If left unspecified,
<generate>task will write under MPS home and this can be problematic in case of multiple builds running from the same MPS home in parallel.Add an Ant property for the JNA path so that it can be easily overridden.
When running tests from the generic distribution the path has to be overridden to point to the platform-specific subdirectory. However, it was previously hardcoded to
${artifacts.mps}/lib/jnaand impossible to override.