feature: Add dependencyModules request support #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone can take a look at build-server-protocol/bsp-testkit2#41 ? I would be able to add proper tests here. Will try adding unit tests for the time being. |
|
I added unit tests, but need the other PR to do some integration ones. Anyone willing to take a look? 😅 |
tgodzik
commented
Mar 14, 2024
server/src/main/kotlin/org/jetbrains/bsp/bazel/server/sync/DependencyMapper.kt
Outdated
Show resolved
Hide resolved
agluszak
requested changes
Mar 27, 2024
server/src/main/kotlin/org/jetbrains/bsp/bazel/server/sync/BspProjectMapper.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/org/jetbrains/bsp/bazel/server/sync/DependencyMapper.kt
Outdated
Show resolved
Hide resolved
server/src/test/kotlin/org/jetbrains/bsp/bazel/server/sync/DependencyMapperTest.kt
Show resolved
Hide resolved
server/src/main/kotlin/org/jetbrains/bsp/bazel/server/sync/DependencyMapper.kt
Outdated
Show resolved
Hide resolved
This would be super useful to use as an alternative to libraries request, which is not standard BSP request.
tgodzik
force-pushed
the
add-dep-module
branch
2 times, most recently
from
7081135
to
6beffe9
Compare
agluszak
approved these changes
Mar 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be super useful to use as an alternative to libraries request, which is not standard BSP request.
Tests depends on build-server-protocol/bsp-testkit2#41