Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix publishing warnings #547

Merged
merged 2 commits into from Apr 18, 2024
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Mar 26, 2024

Previously, no (Scala) warnings would be reported since they would come inside stderr in a progress build event. Now, they are handled via that event and cleared correctly when needed.

Are there any diagnostics tests in integration tests anywhere that I could use as examples?

@agluszak
Copy link
Contributor

Are there any diagnostics tests in integration tests anywhere that I could use as examples?

sadly - no :( but I'll gladly help you design some

@tgodzik
Copy link
Contributor Author

tgodzik commented Mar 27, 2024

Are there any diagnostics tests in integration tests anywhere that I could use as examples?

sadly - no :( but I'll gladly help you design some

Here https://github.com/build-server-protocol/bsp-testkit2 right? That's the testkit being used in current repository? It seems that it's released manually if I am not mistaken

@agluszak
Copy link
Contributor

agluszak commented Mar 27, 2024

That's the testkit being used in current repository?

yes

It seems that it's released manually if I am not mistaken

I don't think we've ever made a release to maven. Here it is depended upon as a bazel module: https://github.com/JetBrains/bazel-bsp/blob/master/MODULE.bazel#L29

@tgodzik
Copy link
Contributor Author

tgodzik commented Mar 29, 2024

Are there any diagnostics tests in integration tests anywhere that I could use as examples?

sadly - no :( but I'll gladly help you design some

Should be enough to do build-server-protocol/bsp-testkit2#45, what do you think?

@agluszak agluszak changed the title bugfix: Fix publishing warnings [fix] Fix publishing warnings Apr 17, 2024
@agluszak
Copy link
Contributor

Hey, any update on this?

In order to add a test you can add a new scala target here and add a test here.

Previously, no (Scala) warnings would be reported since they would come inside stderr in a progress build event. Now, they are handled via that event and cleared correctly when needed.
@agluszak agluszak merged commit 45d83ef into JetBrains:master Apr 18, 2024
12 checks passed
@tgodzik tgodzik deleted the fix-scala-warns branch April 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants