New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix publishing warnings #547
Conversation
sadly - no :( but I'll gladly help you design some |
Here https://github.com/build-server-protocol/bsp-testkit2 right? That's the testkit being used in current repository? It seems that it's released manually if I am not mistaken |
server/src/main/kotlin/org/jetbrains/bsp/bazel/server/diagnostics/DiagnosticsService.kt
Show resolved
Hide resolved
yes
I don't think we've ever made a release to maven. Here it is depended upon as a bazel module: https://github.com/JetBrains/bazel-bsp/blob/master/MODULE.bazel#L29 |
Should be enough to do build-server-protocol/bsp-testkit2#45, what do you think? |
Previously, no (Scala) warnings would be reported since they would come inside stderr in a progress build event. Now, they are handled via that event and cleared correctly when needed.
4b25917
to
09e62bb
Compare
e2e/src/main/kotlin/org/jetbrains/bsp/bazel/BazelBspScalaProjectTest.kt
Outdated
Show resolved
Hide resolved
09e62bb
to
c1b04af
Compare
Previously, no (Scala) warnings would be reported since they would come inside stderr in a progress build event. Now, they are handled via that event and cleared correctly when needed.
Are there any diagnostics tests in integration tests anywhere that I could use as examples?