Fix Pager scroll with scrollable content on top #1098
Conversation
...rc/skikoMain/kotlin/androidx/compose/foundation/gestures/cupertino/CupertinoFlingBehavior.kt
Outdated
Show resolved
Hide resolved
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt
Outdated
Show resolved
Hide resolved
| @@ -953,6 +953,9 @@ internal class DefaultFlingBehavior( | |||
| lastAnimationCycleCount++ | |||
| } | |||
| } catch (exception: CancellationException) { | |||
| // This is where the ScrollCancellationException should be caught, | |||
| // but the parent class CancellationException is caught here for | |||
| // backwards compatibility. | |||
There was a problem hiding this comment.
What is "backwards compatibility" here? What cases it covers? Aren't all references in the same module and already updated?
There was a problem hiding this comment.
I mean, we keep handling CancellationException here to catch new potential cases. For example if someone will make similar trick at another place.
There was a problem hiding this comment.
I don't think that we should keep it for that. I hope this will be upstreamed soon to avoid such changes during the merge.
However, I'm not going to block the PR because of this.
cc @igordmn
There was a problem hiding this comment.
If you want to create upstream PR in the close future, let's change. Otherwise it's safer to keep as it is.
There was a problem hiding this comment.
It's planned for the next milestone
Fixes scrolling when the content scrolls in the same direction as its parent Pager node.
ASalavei
added
the
changelog1.6.1
Fixes scrolling when the content scrolls in the same direction as its parent Pager node.
Related MR: #1097
Related Issue: JetBrains/compose-multiplatform#4279