Fix AppStore/TestFlight verification failure due to skiko/skia conflicting names with ICU library #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Mar 4, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Issue JetBrains/compose-multiplatform#3840 - AppStore/TestFlight verification failed due to usage of "non-public ICU symbols" ## Solution Solved in skia/skiko by using new names (with `_skiko` suffix): JetBrains/skia#3 JetBrains/skiko#881 ___ JetBrains/skiko@v0.7.94...v0.7.96 # Conflicts: # gradle/libs.versions.toml
eymar
changed the title
eymar
added
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
JetBrains/compose-multiplatform#3840 - AppStore/TestFlight verification failed due to usage of "non-public ICU symbols"
Solution
Solved in skia/skiko by using new names (with
_skikosuffix):JetBrains/skia#3
JetBrains/skiko#881
JetBrains/skiko@v0.7.94...v0.7.96