Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resources] Fix Res class generation if the library is declared as 'api' #4406

Merged
merged 1 commit into from Mar 4, 2024

Conversation

terrakok
Copy link
Collaborator

@terrakok terrakok commented Mar 1, 2024

To decide whether the gradle plugin need to generate a Res class or not, the plugin searches the resources library in a project dependencies.
Kotlin Gradle plugin provides two configurations: api and implementation. I expected the implementation configuration includes (extends) the api but it was mistake.
The PR added api libraries to a search scope.

fixes #4405

@terrakok terrakok merged commit 7ce3063 into master Mar 4, 2024
6 checks passed
@terrakok terrakok deleted the k.tskh/4405 branch March 4, 2024 10:26
@terrakok terrakok added the changelog1.6.1 Temporary label for 1.6.1 changelog (will be removed) label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog1.6.1 Temporary label for 1.6.1 changelog (will be removed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Library: No code-gen if using "api" instead of "implementation"
2 participants