Upgrade semver checks and set dev version with new compiler plugin. #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Apr 26, 2024
| @@ -49,7 +49,6 @@ class KotlinCompatibilityTest : GradlePluginTestBase() { | |||
| } | |||
| } | |||
|
|
|||
| /* TODO uncomment the test when Kotlin RC2 will be published | |||
There was a problem hiding this comment.
Let's add TODO:
// TODO replace by this after Kotlin 2.0 release
// testEnvironment = defaultTestEnvironment.copy(kotlinVersion = "2.0")
dev kotlin builds can be removed from maven later
MatkovIvan
reviewed
Apr 26, 2024
| assert(Version.fromString("2.0.0-RC3-111") > Version.fromString("2.0.0-RC3-111-9")) | ||
| assert(Version.fromString("2.0.0-RC3-112-9") > Version.fromString("2.0.0-RC3-111-9")) | ||
| assert(Version.fromString("2.0.0") > Version.fromString("2.0.0-RC3-111-9")) | ||
| assert(Version.fromString("2.0.0-RC1") > Version.fromString("2.0.0--")) |
There was a problem hiding this comment.
The check shows what a result will be if versions are that.
I am sure that "2.0.0--" is an invalid semver.
terrakok
force-pushed
the
k.tskh/comp-plugin-dev
branch
from
1684efc
to
9961690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.