[gradle] A flag to disable multimodule resources. #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatkovIvan, please, review as well |
igordmn
reviewed
May 7, 2024
| @@ -22,7 +22,7 @@ internal object ComposeProperties { | |||
| internal const val MAC_NOTARIZATION_PASSWORD = "compose.desktop.mac.notarization.password" | |||
| internal const val MAC_NOTARIZATION_TEAM_ID_PROVIDER = "compose.desktop.mac.notarization.teamID" | |||
| internal const val CHECK_JDK_VENDOR = "compose.desktop.packaging.checkJdkVendor" | |||
| internal const val ALWAYS_GENERATE_RESOURCE_ACCESSORS = "compose.resources.always.generate.accessors" | |||
| internal const val ENABLE_MULTIMODULE_RESOURCES = "compose.resources.multimodule.enable" | |||
There was a problem hiding this comment.
Is it about publication and depending on resource library, or only about publication?
There was a problem hiding this comment.
It is about a publication and a multimoduleness (very close things in the gradle)
There was a problem hiding this comment.
What happen if it is false, and users add a dependency on a library with resources? Will it work without this property?
There was a problem hiding this comment.
Sure. It's false by default and all tests are green at least)
There was a problem hiding this comment.
oh, you meant a library with resources (not the resource's library!). No, it requires the flag
|
Release notes should in this format: Release NotesBreaking changes - Resources
|
MatkovIvan
reviewed
May 7, 2024
gradle-plugins/compose/src/test/test-projects/misc/kmpResourcePublication/gradle.properties
Outdated
Show resolved
Hide resolved
...c/main/kotlin/org/jetbrains/compose/desktop/application/internal/ComposeProjectProperties.kt
Show resolved
Hide resolved
zsmb13
reviewed
May 8, 2024
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/ComposeResources.kt
Outdated
Show resolved
Hide resolved
…ins.compose.resources.multimodule.enable'
… provide a flag to switch on previous behavior
igordmn
approved these changes
May 8, 2024
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/KmpResources.kt
Outdated
Show resolved
Hide resolved
terrakok
changed the title
MatkovIvan
approved these changes
May 8, 2024
…esources/KmpResources.kt Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
terrakok
added a commit
that referenced
this pull request
May 8, 2024
The Compose Multiplatform Resources with the mulimodule.publication support is a new feature and may have some not found problems. The PR introduces a gradle property to switch back to the previous behavior: `org.jetbrains.compose.resources.multimodule.disable=true` ## Testing After update to Kotlin 2.0.0 and CMP 1.6.10 all projects will be switched to the new logic with the multimodule support. Gradle info output should contain a message: ``` Configure KMP resources ``` If the new feature breaks user's projects they may add `org.jetbrains.compose.resources.multimodule.disable=true` to the `gradle.properties` to disable it. After that Gradle info output will contain: ``` Configure compose resources ``` ## Release Notes ### Resources To disable the Compose Resources publication and the multimodule support in cases of problems add `org.jetbrains.compose.resources.multimodule.disable=true` to the root `gradle.properties`. (cherry picked from commit bf6142d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Compose Multiplatform Resources with the mulimodule.publication support is a new feature and may have some not found problems. The PR introduces a gradle property to switch back to the previous behavior:
org.jetbrains.compose.resources.multimodule.disable=trueTesting
After update to Kotlin 2.0.0 and CMP 1.6.10 all projects will be switched to the new logic with the multimodule support.
Gradle info output should contain a message:
If the new feature breaks user's projects they may add
org.jetbrains.compose.resources.multimodule.disable=trueto thegradle.propertiesto disable it. After that Gradle info output will contain:Release Notes
Features - Resources
org.jetbrains.compose.resources.multimodule.disable=trueto the rootgradle.properties.