Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources with cocoapods integration #4783

Merged
merged 3 commits into from May 8, 2024
Merged

Fix resources with cocoapods integration #4783

merged 3 commits into from May 8, 2024

Conversation

terrakok
Copy link
Collaborator

@terrakok terrakok commented May 8, 2024

The PR sets a static path to the compose resources for the cocoapods integration because there maybe only one integration framework for a gradle module.

Fixes #4720

Release Notes

Fixes - Resources

  • (prerelease fix) Fix resources with cocoapods integration

Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please add Release Notes

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving cocoapod configuration to afterEvaluate looks valid to me

@terrakok terrakok merged commit b884678 into master May 8, 2024
12 checks passed
@terrakok terrakok deleted the k.tskh/cocoa-res branch May 8, 2024 19:21
terrakok added a commit that referenced this pull request May 8, 2024
The PR sets a static path to the compose resources for the cocoapods
integration because there maybe only one integration framework for a
gradle module.

Fixes #4720

## Release Notes
### Fixes - Resources
- _(prerelease fix)_ Fix resources with cocoapods integration

(cherry picked from commit b884678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iosApp] org.jetbrains.compose.resources.MissingResourceException with CocoaPods
3 participants