Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Android team doesn't want to use new mockito for now, so, IdeTooltipM…
…anager class cannot be final Close #1226, Close #1228 GitOrigin-RevId: 5404091a287083aaa4856a7261908876efc3486e
- Loading branch information
1 parent
07e34c2
commit d8d2676
Showing
2 changed files
with
4 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8d2676
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this easier on us.
For what it's worth, it's not that we don't want to use a “new mockito”—we use the same version as IntelliJ—but we'd rather not set up extensions for alternative mocking implementations in order to make some classes final when it's simpler to avoid that.
Incidentally test speed is a significant issue for us and the mock-maker-inline extension is much slower; see Mockito issue 1142.
d8d2676
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also Mockito issue 1614.