Add JAR manifest header folding #2755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How should I go about testing? It's a bit of mish-mash looking around at other files |
mkem114
commented
May 12, 2024
| public String getPlaceholderText(@NotNull ASTNode node) { | ||
| if (node.getPsi() instanceof Header) { | ||
| String usefulText = node.getText().trim(); | ||
| if (usefulText.length() <= MAX_BYTES_PER_LINE) { |
There was a problem hiding this comment.
Seems like a useful proxy, the viewer cuts off placeholders that are too long with soft-wrapping (well you can still horizontally scroll).
In this case, adding more detail in the placeholder shouldn't add more cognitive load
mkem114
commented
May 12, 2024
|
|
||
| @Override | ||
| public boolean isCollapsedByDefault(@NotNull ASTNode node) { | ||
| return false; // no change in existing behaviour |
There was a problem hiding this comment.
I think we can avoid this discussion for now. What the heuristic should be, should probably be discussed in an issue IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add folding support to make it easier to wrestle with large files. After this PR I'll add structure support though