KTL-114 Add kotlinx.serialization compiler plugin to Kotlin Playground #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderPrendota
requested changes
Sep 7, 2022
| @@ -113,6 +114,11 @@ class KotlinEnvironment( | |||
| private fun createConfiguration(): CompilerConfiguration { | |||
| val arguments = K2JVMCompilerArguments() | |||
| parseCommandLineArguments(additionalCompilerArguments, arguments) | |||
|
|
|||
| if (compilerPlugins.isNotEmpty()) { | |||
There was a problem hiding this comment.
is it possible to pass arguments only if we need plugins?
There was a problem hiding this comment.
Sorry, I am not sure what you mean.
The arguments are passed only if the plugin was defined if the build.gradle.kts.
So, for me, it is what you asked for :)
There was a problem hiding this comment.
it's not necessary to have compiler plugins if we don't use them in the code
nikpachoo
force-pushed
the
ktl-114-support-kotlinx-serialization
branch
from
b459f17
to
9651928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a draft for supporting kotlinx.coroutines.
Status note:
These changes are not working for some reason. I am trying to find out what is wrong.