Update 3 dependencies from npm #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependencies[bot]](https://avatars.githubusercontent.com/in/2310?s=60&v=4){kind=small}
|
@princed using binary search, I found out that it's |
|
@Hypnosphi I'll have a look |
|
You may want to fix it with following patch (makes sense anyway) or wait for princed/postcss-modules-values-replace/issues/23: diff --git a/components/global/global.css b/components/global/global.css
index f174f480e..f7896c77c 100644
--- a/components/global/global.css
+++ b/components/global/global.css
@@ -78,7 +78,7 @@
@value alert-z-index: 6;
/* Note: footer also has top margin which isn't taken into account here */
-@value footer-height: calc(unit*8);
+@value footer-height: calc(unit * 8);
/* Media breakpoints (minimal values) */
@value breakpoint-small: 640px;
diff --git a/components/grid/grid.css b/components/grid/grid.css
index c8fb2c14c..d00e1bab9 100644
--- a/components/grid/grid.css
+++ b/components/grid/grid.css
@@ -1,7 +1,7 @@
@value unit, breakpoint-small, breakpoint-middle, breakpoint-large, large-screen-media, middle-screen-media, small-screen-media from '../global/global.css';
-@value gutterWidth: (unit*2);
+@value gutterWidth: (unit * 2);
@value gutterCompensation: calc(gutterWidth / -2);
-@value outerMargin: calc(unit*2);
+@value outerMargin: calc(unit * 2);
@value containerSmall: calc(breakpoint-small + gutterWidth);
@value containerMedium: calc(breakpoint-middle + gutterWidth);
@value containerLarge: calc(breakpoint-large + gutterWidth); |
|
Fixed in 3.0.0, no migration required for ring-ui |
|
Cool, thanks. Will add the spaces anyway (I wonder can that be a stylelint rule) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The following dependencies have been updated:
css-loaderin/from "0.28.8" to "0.28.9"postcss-modules-values-replacein/from "2.0.0" to "2.0.2"react-virtualizedin/from "9.17.2" to "9.17.3"Details
Dependencies.io has updated
css-loader(a npm dependency in/) from "0.28.8" to "0.28.9".0.28.9
2018-01-17
Bug Fixesurl()) (#663) (d1d8221)Dependencies.io has updated
postcss-modules-values-replace(a npm dependency in/) from "2.0.0" to "2.0.2".2.0.2
No content found. Please open an issue at https://github.com/dependencies-io/support if you think this content could have been found.
Dependencies.io has updated
react-virtualized(a npm dependency in/) from "9.17.2" to "9.17.3".9.17.3
No content found. Please open an issue at https://github.com/dependencies-io/support if you think this content could have been found.