Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added draw matches to write text and no lines as mode=3. #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added draw matches to write text and no lines as mode=3. #13

wants to merge 3 commits into from

Conversation

mpkuse
Copy link
Contributor

@mpkuse mpkuse commented Oct 31, 2017

When there are a lot of matches it is hard to see the correct matches. So instead of lines, I draw circles and write text (serial number of the match) to the image. Basically, I have edited your DrawInlier().

Manohar Kuse added 2 commits October 31, 2017 13:57
Added draw matches to write text and no lines as mode=3. More testing…
a0d09d5 
… with my images
Added class GmsRobe. This class is an extention of original class to …
41e1ea7 
…provide functionality like match3(), match2_guided() in addition to original. Returns image cords.
@JiawangBian
Copy link
Owner

Hey mpkuse,

Thanks for your commits, and I would like to integrate it into the code. I give some suggestions before merging:

  1. Formatting the name of photos, as one may not understand the which pairs should be matched.
  2. Replacing "boost/timer" in cpp codes with the standard library for convenience, as many guys may not get boost library installed.
  3. I have invited Konrad who implemented the original python code to check out the change. He may give suggestions below about the python scripts.

Best,
JiaWang

@mpkuse
Copy link
Contributor Author

mpkuse commented Nov 2, 2017

Sure, I will follow your suggestion and add another commit soon.

@kczarnota
Copy link
Contributor

Hi mpkuse,

Thanks for your updates!

I have a few suggestions:

  1. Can you change syntax to match Python3? The script was originally developed to support it.
  2. Can you remove all unnecessary comments? I see quite a lot of code which is commented out.
  3. Can you write something more about GmsRobe, which is a new functionality? Did you invented it yourself or it's a implementation of known algorithm(if yes pleas provide a link where I could read more about it).

Best,
Konrad

@mpkuse
Copy link
Contributor Author

mpkuse commented Nov 2, 2017

What do you exactly mean by syntax to match python3?

I will get rid of the commented code. Basically, I added the main in a separate script and class in separate so that in my projects (and for others) can simply copy the class file and follow examples from demo.py file.

GmsRobe is my original work to extend the functionality. I will write a short readme for this.

I think I will need a couple of days to fix this up.

Wrote a readme for images.
709a1da 
wrote a readme for python usage.

removed boost timer usage. Essentially there is now no change in the
original c++ code.

I have got rid of all the unnecessary comments in code. moved the
main into demo.py. The user is supposed to just run demo.py.
It has 4 usages to choose from by keyboard input.
This demos the GmsMatcher class and GmsRobe class.
@kczarnota
Copy link
Contributor

I couldn't run your code because you use print function without parentheses. Please try to run your code with Python3 interpreter and it will tell you if there are any problems.

Take your time with changes, it's not a race :)

@mpkuse mpkuse mentioned this pull request Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpkuse @JiawangBian @kczarnota