[WIP] android jcenter fix

[daniellacosse]

Jcenter/bintray is broken, but our cordova-android fetches from there. Fix for this was introduced July of last year.

• Upgrades cordova-android to latest.
• TODO: Address breaking change introduced to WebViewAssetLoader in v10.0.0 (https://cordova.apache.org/announcements/2021/07/20/cordova-android-10.0.0.html)

[fortuna]

The change looks fine, but we need to confirm if storage if preserved after an upgrade.

[daniellacosse]

The change looks fine, but we need to confirm if storage if preserved after an upgrade.

I presume setting <preference name="AndroidInsecureFileModeEnabled" value="true" /> isn't a viable option?

Is everything exclusively stored via local storage? I haven't tested it yet, but if so it's very likely this will dump everyone's configs.

[daniellacosse]

The change looks fine, but we need to confirm if storage if preserved after an upgrade.

I presume setting <preference name="AndroidInsecureFileModeEnabled" value="true" /> isn't a viable option?

Is everything exclusively stored via local storage? I haven't tested it yet, but if so it's very likely this will dump everyone's configs.

seems mostly like it's the language of choice, unless vscode is hiding results from me again

https://github.com/Jigsaw-Code/outline-client/blob/0571eafe2d14a33b2e3bb8c329169fefcc2805bb/src/www/app/app.ts#L249-L250

[fortuna]

We use localStorage for everything: https://github.com/Jigsaw-Code/outline-client/search?q=localStorage&type=

We had to migrate uses on iOS from file:// to app://localhost once and it was a pain. You'll see the code there.

I think the AndroidInsecureFileModeEnabled is ok, since we don't load files from file:// that we don't trust.
I'm ok with setting that, but I want to make sure the data is preserved in that case too. And if we are testing that the data is preserved, we might asa well test without that option too.

[fortuna]

Let me know when you have verified it's working with the update.

[daniellacosse]

We use localStorage for everything: https://github.com/Jigsaw-Code/outline-client/search?q=localStorage&type=

We had to migrate uses on iOS from file:// to app://localhost once and it was a pain. You'll see the code there.

I think the AndroidInsecureFileModeEnabled is ok, since we don't load files from file:// that we don't trust. I'm ok with setting that, but I want to make sure the data is preserved in that case too. And if we are testing that the data is preserved, we might asa well test without that option too.

In the search you linked, the only call to setItem was to the overrideLanguage key, so you can understand my confusion. I assume then that some third-party is using it somehow.

Apologies on the delay, I'm trying to figure out how best to do this.

[daniellacosse]

ah, I was being a bit silly - I never got the android app to build on my local mac and was trying to see if I could solve that, either with Android Studio w/ Blaze (recency bias 😅) or manually - only to realize I can't build the old version locally because of this very issue!!

Then, of course, I remembered that the build system has been building versions of the android app this whole time 🤦 . Here are the builds of note while I struggle to figure out what how to install each apk on my emulator:

• cordova-android v9 build
• cordova-android v10 build
• "insecure file" cordova-android v10 build

My main concern right now is - will the emulator preserve localStorage across the different apks? Or does it treat each as its own separate app? I don't even know how that works.

[daniellacosse]

This was useful while trying to get the app to build on my local machine. jenv uses it to manage which version of java it should use - our app uses v1.8 while android studio with blaze defaults to 11.0.11

[jyyi1]

Maybe a question for @fortuna , shall we upgrade Java to a newer version considering we are approaching the end-of-support time of Java 8: https://endoflife.date/java.

[fortuna]

Yes, let's upgrade to the newest Java if we can. But in another PR

[fortuna]

Let's submit this as is to unblock the other stuff, with the understanding that we still need to test it.