Replace references of static externs to addr_of!. We need to do this … #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing. But I think this is not because of this PR. If you want, I can try to fix CI anyway |
added 2 commits
April 20, 2024 23:48
…5" in our dependency tree, which requires rustc 1.63.0
… this, so let's do the same
|
@JohnTitor , I fixed CI!!! I added two commits (second and third), and now CI works. First commit (i. e. introducing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…because of rust-lang/rust#114447 .
I need this, because I plan to send PR to crate libc, which will add
environstatic extern for UNIX. Unfortunately,environgenerates annoying warning during testing due to rust-lang/rust#114447 , so I'm sending this PR to ctest2 first.I tested this ctest2 PR with my fork of crate libc, which adds
environ, and all works great.Also, even if you opposed to proposed crate libc change, this ctest2 PR is of general usefulness anyway.
Also, this ctest2 PR always unconditionally generates
addr_of!invocation. This is okay, because ctest2's MSRV is 1.56.0, andaddr_of!was added in 1.51.0.Please, make ctest2 release after this PR is applied