Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image stats to metadata #525

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nick-vincent
Copy link
Contributor

Meant to address #377


Quick Checklist

  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2023

⚠️ No Changeset found

Latest commit: 91da726

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #525 (91da726) into main (bbfa8ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          33       33           
  Lines        1149     1151    +2     
  Branches      238      238           
=======================================
+ Hits         1114     1116    +2     
  Misses         35       35           
Flag Coverage Δ
imagetools-core 98.72% <100.00%> (+<0.01%) ⬆️
rollup-plugin-imagetools 99.25% <ø> (ø)
vite-imagetools 85.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/src/lib/apply-transforms.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@manucorporat
Copy link

What would take to merge this?

@benmccann
Copy link
Collaborator

This feels a bit difficult to use from the user's side. I think something like #662 with an option to use the dominant color would probably be more user friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants