Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using fs/promises #675

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: avoid using fs/promises #675

merged 1 commit into from
Dec 19, 2023

Conversation

benmccann
Copy link
Collaborator

It might be less reliable since it's newer? (example: nodejs/node#51031)

People are reporting weird errors (sveltejs/kit#11098) and this is my best guess at the moment

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 86967b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0df85ac) 93.60% compared to head (86967b9) 93.60%.

Files Patch % Lines
packages/vite/src/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          32       32           
  Lines        1189     1189           
  Branches      189      189           
=======================================
  Hits         1113     1113           
  Misses         76       76           
Flag Coverage Δ
imagetools-core 97.01% <ø> (ø)
vite-imagetools 78.44% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benmccann benmccann merged commit 216e40a into main Dec 19, 2023
8 of 10 checks passed
@benmccann benmccann deleted the rm-fs-promises branch December 19, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant