-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std support #33
Add no_std support #33
Conversation
Refusing to touch the Changelog, since:
The error impls are not from core, because: rust-lang/rust#103765 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 90.17% 90.35% +0.17%
==========================================
Files 2 2
Lines 1547 1555 +8
==========================================
+ Hits 1395 1405 +10
+ Misses 152 150 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the commit message line
(cherry picked from commit 191d4f4)
from the commit.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b3eb624
into
JonathanWoollett-Light:master
(cherry picked from commit 191d4f4)
Summary of the PR
Please summarize here why the changes in this PR are needed.
It makes this crate actually usable in no_std environments.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.