Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std support #33

Merged

Conversation

C0D3-M4513R
Copy link
Contributor

@C0D3-M4513R C0D3-M4513R commented Mar 12, 2024

(cherry picked from commit 191d4f4)

Summary of the PR

Please summarize here why the changes in this PR are needed.

It makes this crate actually usable in no_std environments.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@C0D3-M4513R
Copy link
Contributor Author

C0D3-M4513R commented Mar 12, 2024

Refusing to touch the Changelog, since:

You don't need to edit the changelog it is automatically generated from commit messages.

The error impls are not from core, because: rust-lang/rust#103765
That's also the same reason, why std enabled by default.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 94.63087% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.35%. Comparing base (1a64e5d) to head (e73c90e).
Report is 5 commits behind head on master.

Files Patch % Lines
ux2-macros/src/lib.rs 95.91% 6 Missing ⚠️
ux2/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   90.17%   90.35%   +0.17%     
==========================================
  Files           2        2              
  Lines        1547     1555       +8     
==========================================
+ Hits         1395     1405      +10     
+ Misses        152      150       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JonathanWoollett-Light JonathanWoollett-Light left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the commit message line

(cherry picked from commit 191d4f4)

from the commit.

@C0D3-M4513R
Copy link
Contributor Author

Done

Copy link
Owner

@JonathanWoollett-Light JonathanWoollett-Light left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JonathanWoollett-Light JonathanWoollett-Light merged commit b3eb624 into JonathanWoollett-Light:master Mar 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants