New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update cspell config #342
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 35 35
Lines 6406 6406
Branches 360 360
=======================================
Hits 5139 5139
Misses 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dcfd824
to
5b0893f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new recommended style.
I don't love having two config files now 😕 where is this new style recommended from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective this is a net negative. I'd like to reduce the number of config files in projects (https://github.com/JoshuaKGoldberg/create-typescript-app/milestone/3).
We could put a lot of the config files in a sub |
Yeah IMO having as few files as possible is a good goal. Splitting into sub-directories still means there's more stuff to parse through. Aside: IIRC there is/was a movement to make |
PR Checklist
status: accepting prs
Overview
Updates cspell config to new recommended style.