Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cspell config #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update cspell config #342

wants to merge 1 commit into from

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

Overview

Updates cspell config to new recommended style.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f12728a) 80.22% compared to head (5b0893f) 80.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          35       35           
  Lines        6406     6406           
  Branches      360      360           
=======================================
  Hits         5139     5139           
  Misses       1267     1267           
Flag Coverage Δ
4.3.5 80.00% <ø> (ø)
4.6.4 80.03% <ø> (ø)
4.9.5 80.03% <ø> (ø)
latest 80.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new recommended style.

I don't love having two config files now 😕 where is this new style recommended from?

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my perspective this is a net negative. I'd like to reduce the number of config files in projects (https://github.com/JoshuaKGoldberg/create-typescript-app/milestone/3).

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Dec 24, 2023
@RebeccaStevens
Copy link
Collaborator Author

We could put a lot of the config files in a sub config directory. Would that work or do just want to reduce file count?
A lot of configs can be put into package.json but I don't like polluting that file with configs.

@JoshuaKGoldberg
Copy link
Owner

Yeah IMO having as few files as possible is a good goal. Splitting into sub-directories still means there's more stuff to parse through.

Aside: IIRC there is/was a movement to make .config a standard, but since not every tool supports it I think it'd be potentially more confusing to folks to have two places to put configs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants