Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for metadata credential fetching #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for metadata credential fetching #32

wants to merge 2 commits into from
+3 −2

Conversation

contradict
Copy link

The first change is for a change in the Julia HTTP library, data is now body.

The second is for a change it the Google API, the format of the Content-Type header has changed.

With these two changes, MetadataCredentials works on GCE instances.

@russelhowe
Fix MetadataCredentials for new HTTP
28ecc02 
.data -> .body
@russelhowe
Fix parsing of Content-Type header
09286ba 
There are now two values in one header:
    application/json; charset=utf-8
Split on the semicolon and check the first part.
@mattBrzezinski
Copy link
Member

This package doesn't look like it gets too much attention sadly. When I have some spare time I can look into the CI error and fix it.

Would you mind possibly adding some tests to this? Although looking at what exists currently there doesn't seem to be much there.

@mattBrzezinski mattBrzezinski self-assigned this Sep 10, 2020
@JockLawrie
Copy link
Contributor

Hi Matt, I am no longer using GCP and therefore am no longer maintaining this package. If you'd like to fork this repo I'll link to the fork from here and archive this repo.

@mattBrzezinski
Copy link
Member

Hi Matt, I am no longer using GCP and therefore am no longer maintaining this package. If you'd like to fork this repo I'll link to the fork from here and archive this repo.

I think it can continue to live in the JuliaCloud org, it seems like an appropriate place.

@Alexander-Barth
Copy link

I can confirm that this PR is still necessary for MetadataCredentials().
Would it be possible of somebody from the JuliaCloud org would merge this PR?

Thanks for this great package (and PR :-)) !

@Alexander-Barth Alexander-Barth mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattBrzezinski mattBrzezinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@contradict @mattBrzezinski @JockLawrie @Alexander-Barth @russelhowe