Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos CI job for PRs that don't edit any files or do edit binary files #52600

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Dec 21, 2023

Fixes #52599.

Two issues, each fixed by its own commit

  1. mis-handling empty sets of "new" and "old" files (e.g. if a PR exclusively adds files, we considered the whole repo's typos to be false positives rather than assuming no false positives)
  2. crashing on binary files

These two combined cause crashing on any PR that exclusively adds or exclusively removes files.

The github history is a hot mess but the git history should be pristine.

@LilithHafner LilithHafner added the status:DO NOT MERGE Do not merge this PR! label Dec 21, 2023
@LilithHafner LilithHafner force-pushed the lh/typos-fixup branch 4 times, most recently from 736e8e9 to c6c93cf Compare December 21, 2023 03:07
@LilithHafner LilithHafner changed the base branch from master to lh/fix-typos-base December 21, 2023 03:10
@LilithHafner LilithHafner changed the base branch from lh/fix-typos-base to master December 21, 2023 03:41
@LilithHafner LilithHafner deleted the lh/typos-fixup branch December 21, 2023 03:44
@LilithHafner LilithHafner restored the lh/typos-fixup branch December 21, 2023 03:47
@LilithHafner LilithHafner reopened this Dec 21, 2023
@LilithHafner LilithHafner changed the base branch from master to lh/fix-typos-base December 21, 2023 03:57
@LilithHafner LilithHafner changed the base branch from lh/fix-typos-base to lh/typos-fixup-base December 21, 2023 04:01
@LilithHafner LilithHafner reopened this Dec 21, 2023
@LilithHafner LilithHafner changed the base branch from lh/typos-fixup-base to master December 21, 2023 04:05
@LilithHafner LilithHafner removed the status:DO NOT MERGE Do not merge this PR! label Dec 21, 2023
@LilithHafner LilithHafner marked this pull request as ready for review December 21, 2023 04:08
@LilithHafner LilithHafner requested a review from a team as a code owner December 21, 2023 04:08
@LilithHafner LilithHafner added kind:bugfix This change fixes an existing bug domain:ci Continuous integration labels Dec 21, 2023
@LilithHafner
Copy link
Member Author

Ideally, I'd like to merge this PR before #45641 so that we can see the fix in the wild and get an extra confirmation that it works.

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@LilithHafner LilithHafner changed the title Fix typos CI job Fix typos CI job for PRs that don't edit any files or do edit binary files Dec 21, 2023
@LilithHafner LilithHafner merged commit 34d1b71 into JuliaLang:master Dec 21, 2023
6 of 8 checks passed
@LilithHafner LilithHafner deleted the lh/typos-fixup branch December 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ci Continuous integration kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos CI check crashed
2 participants