Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document module docstring scope #54429

Merged
merged 3 commits into from
May 25, 2024

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented May 10, 2024

Add a minor note to the documentation about the scope module docstrings are evaluated in, with an example and a simple test.

Cf discussion

@tpapp
Copy link
Contributor Author

tpapp commented May 22, 2024

Friendly ping, could someone review and possibly merge this trivial doc PR? It looks like the CI failures are unrelated.

@tpapp tpapp added domain:docs This change adds or pertains to documentation modules labels May 22, 2024
@fingolfin fingolfin added the status:merge me PR is reviewed. Merge when all tests are passing label May 24, 2024
@fingolfin
Copy link
Contributor

Thank you @tpapp and sorry for the delay. I am re-running CI now just in case, once that is through someone can review the failures, if any, and hopefully we can get this merged RSN

@fatteneder fatteneder merged commit d8f37c9 into JuliaLang:master May 25, 2024
8 checks passed
@fatteneder fatteneder removed the status:merge me PR is reviewed. Merge when all tests are passing label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants