Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland " Use copyto! in converting Diagonal/Bidiagonal/Tridiagonal to Matrix #53912 " #54459

Merged
merged 3 commits into from
May 15, 2024
Merged

Reland " Use copyto! in converting Diagonal/Bidiagonal/Tridiagonal to Matrix #53912 " #54459

merged 3 commits into from
May 15, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented May 14, 2024

This was reverted in #54332, but the core idea is unrelated to the _unsetindex! change. The tests for undef indices are now reverted.

@jishnub jishnub mentioned this pull request May 14, 2024
Merged
@dkarrasch dkarrasch added the domain:linear algebra Linear algebra label May 14, 2024
@giordano giordano added the kind:re-land This relands a PR that was previously merged but was later reverted. label May 14, 2024
@dkarrasch
Copy link
Member

Ready to go, isn't it?

@jishnub
Copy link
Contributor Author

jishnub commented May 15, 2024

Yes, it's ready

@dkarrasch dkarrasch merged commit 28aaafc into master May 15, 2024
7 of 9 checks passed
@dkarrasch dkarrasch deleted the jishnub/structuredtomatrixcopyto branch May 15, 2024 18:02
jishnub added a commit that referenced this pull request May 17, 2024
@jishnub
Reland "Support broadcasting over structured block matrices #53909" (#…
81cb537 
…54460)

This was reverted in #54332. This
needs #54459 for the tests to
pass. Opening this now to not forget about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra kind:re-land This relands a PR that was previously merged but was later reverted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jishnub @dkarrasch @giordano