Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump webpack from 4.28.4 to 4.29.0 #280

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jan 20, 2019

Bumps webpack from 4.28.4 to 4.29.0.

Release notes

Sourced from webpack's releases.

v4.29.0

Features

  • update acorn to v6
  • limit the number of in parallel written output files to 15
  • add output.futureEmitAssets which gives the emitting logic of webpack 5
    • assets are replaced with SizeOnlySources
    • reading assets after emitting is no longer allowed
    • This allows memory to be garbage-collected
Commits
  • 25bccd4 4.29.0
  • 6389e41 Merge pull request #8642 from webpack/memory/future-emit-assets
  • 6e383cf make test for Source.buffer more strict
  • aaf85db add output.futureEmitAssets
  • 03ffa48 Merge pull request #8639 from webpack/memory/limit-parallelism
  • 2b2c17f Merge pull request #8598 from kiliancs/acorn6
  • 80514cc Add ts declarations
  • 78abf04 Use eachLimit instead even though forEachLimit apears to be an alias...
  • 9cb4225 forEach to forEachLimit
  • ef67132 Upgrade acorn to v6
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the 🤖 Automatic Issues/pull requests marked with this label were generated automatically by our helper bots. label Jan 20, 2019
@JustArchi JustArchi removed the request for review from Aareksio January 20, 2019 21:38
@Aareksio
Copy link
Member

Not sure why it failed, seems like babel-plugin-syntax-dynamic-import is not loaded... Gonna check.

@JustArchi
Copy link
Member

I checked past commits and all was fine so it's either node regression or webpack 4.29, if it was just a temporary failure I'd restart the CI (and it'd be heavily unlikely that both travis and appveyor failed, so total of 4 different tasks on 3 different OSes).

@Aareksio
Copy link
Member

Seems to be an issue related to npm package deduping as per webpack/webpack#8656

Although the workaround is possible, I prefer to wait for this to be fixed in upstream.

@JustArchi
Copy link
Member

Dependabot will automatically open new PR when new version gets released, so if you believe it'll be fixed upstream, it's alright to just wait for that to happen. Thanks for investigating 👍.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-4.29.0 branch 5 times, most recently from 974aed6 to 338c0e3 Compare January 25, 2019 17:39
@codeclimate
Copy link

codeclimate bot commented Jan 25, 2019

Code Climate has analyzed commit 98d99fc and detected 0 issues on this pull request.

View more on Code Climate.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-4.29.0 branch 2 times, most recently from f4e389c to ca03772 Compare January 29, 2019 01:44
@JustArchi
Copy link
Member

@Aareksio webpack/webpack#8656 (comment)

Note that afaik you only need to latest npm version to upgrade webpack. This should result in a correct lockfile which is installable with older version. As long as you don't run npm dedupe which an old version you are fine.

Once NPM with that fix is in, you should be able to do npm update on this branch and make it work 🙂.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-4.29.0 branch 3 times, most recently from a3ab6dd to 7966e39 Compare February 4, 2019 14:31
Bumps [webpack](https://github.com/webpack/webpack) from 4.28.4 to 4.29.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v4.28.4...v4.29.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-4.29.0 branch from 7966e39 to 98d99fc Compare February 4, 2019 16:44
@dependabot-preview
Copy link
Contributor Author

Superseded by #356.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/webpack-4.29.0 branch February 4, 2019 17:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 Automatic Issues/pull requests marked with this label were generated automatically by our helper bots.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants