New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump webpack from 4.28.4 to 4.29.0 #280
Conversation
Not sure why it failed, seems like babel-plugin-syntax-dynamic-import is not loaded... Gonna check. |
I checked past commits and all was fine so it's either node regression or webpack 4.29, if it was just a temporary failure I'd restart the CI (and it'd be heavily unlikely that both travis and appveyor failed, so total of 4 different tasks on 3 different OSes). |
Seems to be an issue related to npm package deduping as per webpack/webpack#8656 Although the workaround is possible, I prefer to wait for this to be fixed in upstream. |
Dependabot will automatically open new PR when new version gets released, so if you believe it'll be fixed upstream, it's alright to just wait for that to happen. Thanks for investigating 👍. |
974aed6
to
338c0e3
Compare
Code Climate has analyzed commit 98d99fc and detected 0 issues on this pull request. View more on Code Climate. |
f4e389c
to
ca03772
Compare
@Aareksio webpack/webpack#8656 (comment)
Once NPM with that fix is in, you should be able to do |
a3ab6dd
to
7966e39
Compare
Bumps [webpack](https://github.com/webpack/webpack) from 4.28.4 to 4.29.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.28.4...v4.29.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
7966e39
to
98d99fc
Compare
Superseded by #356. |
Bumps webpack from 4.28.4 to 4.29.0.
Release notes
Sourced from webpack's releases.
Commits
25bccd4
4.29.06389e41
Merge pull request #8642 from webpack/memory/future-emit-assets6e383cf
make test for Source.buffer more strictaaf85db
add output.futureEmitAssets03ffa48
Merge pull request #8639 from webpack/memory/limit-parallelism2b2c17f
Merge pull request #8598 from kiliancs/acorn680514cc
Add ts declarations78abf04
Use eachLimit instead even though forEachLimit apears to be an alias...9cb4225
forEach to forEachLimitef67132
Upgrade acorn to v6Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.If all status checks pass Dependabot will automatically merge this pull request.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.