Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support for markdown #188

Merged
merged 6 commits into from Nov 29, 2020
Merged

feat: add basic support for markdown #188

merged 6 commits into from Nov 29, 2020

Conversation

JustinBeckwith
Copy link
Owner

@JustinBeckwith JustinBeckwith commented Nov 26, 2020

This adds a --markdown flag that allows for basic markdown link scanning. When passing --markdown on the CLI or setting the markdown: true option, markdown in the local directory will be rendered as HTML and scanned.

@JustinBeckwith JustinBeckwith marked this pull request as draft November 26, 2020 18:38
@JustinBeckwith JustinBeckwith marked this pull request as ready for review November 28, 2020 18:26
@JustinBeckwith JustinBeckwith changed the title feat: add support for markdown feat: add basic support for markdown Nov 28, 2020
@JustinBeckwith JustinBeckwith merged commit 524f600 into master Nov 29, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 30, 2020

@JustinBeckwith have you thought about an alternative implementation? The express package is a substantial addition, aprox. 25% :/

https://packagephobia.com/result?p=linkinator

@JustinBeckwith
Copy link
Owner Author

I mean, I could look at going back to the raw HTTP server. Generally for dev packages like this, which never really running the browser, I pay a little bit less attention to package size (unless it's egregious). Want to file a issue so I don't lose track of this?

@XhmikosR
Copy link
Contributor

XhmikosR commented Dec 1, 2020

Done. See #196. I agree it's not a huge deal, but we should all pay attention to package sizes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants