Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct c++ syntax for localTypeForElement [2] #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anoymouserver
Copy link
Contributor

fixes #210

Now also tested with the ihc_wsdl, one wsdl matching the issue and some of my local ones.

Copy link
Member

@dfaure-kdab dfaure-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for the investigation and fix.

But what about storing a correct local type instead of changing it on the fly every time it's requested?
i.e. this could be done in TypeMap::addSchemaTypes where localType is set.

(this means reverting the change in TypeMap::localInputType)

Doing it that way will also fix the problem that right now TypeMap::localTypeForAttribute forgets to do it....

It will also make debugging easier because e.g. dump() will show the real local type as it will show up in C++ code.

@anoymouserver
Copy link
Contributor Author

I'll look at this proposal. I had mostly oriented myself on TypeMap::localType and had not studied the class in depth.

So you would store the converted, syntactically correct type directly in entry.localType?

@dfaure-kdab
Copy link
Member

Yes. The localType is the C++ type to be used.

@winterz
Copy link
Member

winterz commented May 22, 2021

Any interest in reviving this patch? I'd like to release new kdsoap version soon

@anoymouserver
Copy link
Contributor Author

Currently I don't have enough time to dive into it and implement the proposed solution.

@winterz
Copy link
Member

winterz commented May 23, 2021

no prob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kdwsdl2cpp generates invalid class name
3 participants