Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update and dedupe dependencies #696

Merged
merged 3 commits into from Dec 16, 2022

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Dec 14, 2022

Integration tests, e.g., this one have started to fail because the node develop image has upgraded polkadot dependencies to 0.9.32, and that has apparently some breaking changes which have been fixed in a polkadot version later than what we currently have in the SDK.

This PR updates the @polkadot/api-related dependencies to the latest published version, so it is possible to run integration tests against develop again.

@ntn-x2 ntn-x2 self-assigned this Dec 14, 2022
@ntn-x2 ntn-x2 changed the title deps: update and dedupe dependencies chore: update and dedupe dependencies Dec 14, 2022
@ntn-x2
Copy link
Member Author

ntn-x2 commented Dec 14, 2022

Not sure what's going on with the bundle tests, but I saw that this also happens in other PRs, so it's most likely unrelated to this one.

@ntn-x2 ntn-x2 mentioned this pull request Dec 14, 2022
3 tasks
@arty-name
Copy link
Collaborator

Yeah, the bundle tests seem completely unrelated to your changes

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rflechtner
Copy link
Contributor

re/ the bundle tests, I think we need to bump playwright to ^1.21.1

microsoft/playwright#13530 (comment)

@ntn-x2
Copy link
Member Author

ntn-x2 commented Dec 16, 2022

Only error in tests is the tx usurped issue. So I will merge this anyway.

@ntn-x2 ntn-x2 merged commit 29e6e64 into develop Dec 16, 2022
@ntn-x2 ntn-x2 deleted the aa/update-polkadot-dependencies branch December 16, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants