Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set git safe.directory in meta tester #3766

Merged
merged 1 commit into from Jan 18, 2023

Conversation

HebaruSan
Copy link
Member

Problem

See KSP-CKAN/NetKAN#9527; the metadata tester is broken, but that attempt has not fixed the problem.

Causes

Probing the docker image, I have slightly more confirmation now that this relates somehow to the permissions of the git repo (see the later comments in KSP-CKAN/NetKAN#9527).

However, there's a big gap in this explanation: NOTHING CHANGED. It's using the same old version of git, GitPython is probably the same, and our code is the same. For this to start happening when it did would imply that GitHub made some change to how Actions handle permissions right at the moment when we were rebuilding this docker image. So 馃し.

Changes

Now the Dockerfile for the meta tester sets git's safe.directory setting to *, which should allow our code to access the repo regardless of the mess that the GitHub Actions framework makes of the ownership or permissions.

I'll self-review this because it's low risk (the thing is already broken) and I want to test it right away.

@HebaruSan HebaruSan added Bug Pull request Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels Jan 18, 2023
@HebaruSan HebaruSan merged commit 34ee679 into KSP-CKAN:master Jan 18, 2023
@HebaruSan HebaruSan deleted the fix/meta-tester branch January 18, 2023 18:31
@HebaruSan
Copy link
Member Author

HebaruSan commented Jan 18, 2023

It didn't work.

@HebaruSan
Copy link
Member Author

At least it fixed local execution (the newline character error is because I'm on Windows right now):

$ docker run -it --workdir /github/workspace -v $(pwd):/github/workspace -e INPUT_SOURCE=commits kspckan/metadata
::warning file=NetKAN/FreeIVAMk3Mk2Passthrough.netkan::Pull requests should have a description with a summary of the changes
::group::NetKAN/FreeIVAMk3Mk2Passthrough.netkan
::error file=NetKAN/FreeIVAMk3Mk2Passthrough.netkan,line=1,col=19::1:19 [new-lines] wrong new line character: expected \n
::endgroup::

ERROR:root:Test of NetKAN/FreeIVAMk3Mk2Passthrough.netkan failed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant