Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: follow neotest-jest changes #1

Merged
merged 6 commits into from
Aug 28, 2022
Merged

feat: follow neotest-jest changes #1

merged 6 commits into from
Aug 28, 2022

Conversation

shiradofu
Copy link

@shiradofu shiradofu commented Jul 17, 2022

upstream changes

I'm using assertionResult.location, which is not currently (2022.07.17) implemented in vitest, would be added before long.
I submitted a small PR.

@shiradofu shiradofu marked this pull request as draft July 17, 2022 10:05
@shiradofu shiradofu marked this pull request as ready for review July 17, 2022 12:05
Copy link
Owner

@KaiSpencer KaiSpencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay on this, missed the notification!
Looks great, thank you for the contribution

@shiradofu
Copy link
Author

Thank you for your review!
I made some additional commits and for now merged them into my own fork.
https://github.com/shiradofu/neotest-vitest/pull/3

Can I submit another RP for this?

@KaiSpencer
Copy link
Owner

@shiradofu Absolutely! It would be great if you could do that

@KaiSpencer KaiSpencer merged commit e329a29 into KaiSpencer:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants