Next version bump (~v4.12.0) #738

teenwolfblitzer · 2021-08-20T23:41:57Z

feat(button group): add wrap option #711 (MED/HIGH) Adds option for button groups to wrap to multiple lines. Default behavior on mobile views has been changed to allow wrapping (other breakpoints are unaffected), so existing uses should be checked to ensure content still flows as expected. Examples include:
- Website Pages and Website Landing Pages: Edit page view - Publish status
- Coupons: Delete coupon confirmation modal
- Offers: Offer export modal
- Email campaigns: Broadcast send type selection
Ensure expandable card is hidden by default #683 (LOW) Fixes a bug in Expandable Card to ensure it does not flash on page load before hiding. Note: Undo this patch after this version bump: https://github.com/Kajabi/kajabi-products/pull/20205
Patch dropdown trigger leading #713 (LOW) Fix to line height in dropdown button trigger fixes tiny alignment issue.
Input Group Message Bug #739 (LOW) Styling adjustment to prevent the button from stretching when input group has message/helper text. No impact is expected but a quick sanity check should be performed.
- Settings/Account Details
Sage dynamic select input - select2 #709 (LOW) Adds dynamic select input
docs(master to main): update the repo's reference to main branch as main #732 (LOW) Docs only update; references to master have been removed
[Sage-511] Sage 3 - Loader Update #737 (LOW) Updates progress bar height and add new "success" variant.
Card row alignment schema #741 (LOW) Internal updates to schema for CardRow component. No impact on usages expected.
Issue Template Update: Suggestion Template #730 (LOW) Docs only update.

teenwolfblitzer · 2021-08-23T19:15:13Z

docs/lib/sage_rails/app/sage_components/sage_component.rb

@@ -31,7 +31,16 @@ def render
    context.render(
      partial: "sage_components/#{template_path}",
      locals: { component: self }
-    ).tap { cleanup_section_vars }
+    ).tap do |html|


This change was reverted in main and will need to be reapplied here prior to the version bump merge.

anechol

LGTM

… SageRails components

…nt contains pre html tags We strip additional whitespace out of the partial's html to allow for cleaner rendering in the browser. In cases where <pre></pre> html tags exist in the returned html, we do not strip any of the whitespace in the partial. In the future we may want more specific string matching as <pre></pre> tag usage grows.

#690

…ontainer margin removed on choice tabs within a button group container. the button group gap setting replaces this need

replace docs description html with markdown

- remove `aria-expanded="false"` filter to aid default - add `overflow: hidden` to aid hiding when `aria-hidden="true"` is not actvated.

…t group to not break layout

…ol a bit

FuturaExtraBold

👍

teenwolfblitzer added the Version Bump label Aug 20, 2021

teenwolfblitzer added this to the v4.13.x milestone Aug 20, 2021

teenwolfblitzer force-pushed the develop branch from e38f1ca to 714b406 Compare August 23, 2021 19:03

teenwolfblitzer commented Aug 23, 2021

View reviewed changes

monicawheeler marked this pull request as ready for review August 25, 2021 15:57

monicawheeler requested review from anechol and FuturaExtraBold August 25, 2021 15:57

monicawheeler self-assigned this Aug 25, 2021

anechol approved these changes Aug 25, 2021

View reviewed changes

Monica Wheeler and others added 21 commits August 25, 2021 11:22

docs(master to main): update the repo's reference to main branch as main

e58782f

refactor(rails sagecomponent class): trims the whitespace rendered by…

a5b0177

… SageRails components

feat(icons): added new icons

e98c541

fix(icons): updated icon names

38ec6b2

fix(icons): menu rename

59a6538

feat(button group): adds wrap option to button group

9e98fe2

#690

feat(button group): update react component

750eac2

docs(button group): updated example wrap button text and icon

ed812ff

feat(sage choice): removes margin on choice tabs using button group c…

99fa1c0

…ontainer margin removed on choice tabs within a button group container. the button group gap setting replaces this need

docs(button): replace docs description html with markdown

0b8bb72

replace docs description html with markdown

fix(expandable-card): ensure card is hidden by default

662f570

- remove `aria-expanded="false"` filter to aid default - add `overflow: hidden` to aid hiding when `aria-hidden="true"` is not actvated.

style(expandable-card): let "on" state for overflow be initial

9578226

chore(dropdown): move button selectors to button stylesheet

db02c6c

fix(button): adjust line-height for trigger to valid setting

0f9b9b8

chore: improve line-height function documentation

b6cef3e

chore: further improve function documentation

7eed754

fix(input group): adjust styling to allow including a message in inpu…

63b3b19

…t group to not break layout

fix(input group): update position styles

f49a38f

feat(dynamic-select): add markup and ruby class

4819e50

feat(dynamic-select): add styles for the dynamic select

2184692

jamell-kajabi and others added 26 commits August 25, 2021 11:23

fix(dynamic_select): add param for pagination size

1c63d38

feat(icons): added new icons

2376723

fix(icons): updated icon names

1ed3d70

fix(icons): menu rename

bf4b20a

feat(link): refactored to use link_to

f4a8bba

feat(link): added preview example

913ee7e

feat(link): preview updates

d656ec6

fix(link): added component.generated_css_classes last

56234fb

feat(link): added prop update

cd2af01

fix(link): logic fix

b7065bd

fix(link): logic fix

fc918c3

fix(link): remove noopener value

3048325

fix(link): switch to content_tag for generating elements

ebd84cd

fix(link): removed the attribute prop in favor of html_attributes

bfe70ea

fix(doc): remove extra tick

771a042

style(loader): updates loading bar height to 6px

a12bf2a

feat(loader): adds new 'success' variant

7390936

fix(loader): fix linting

b74c53a

feat(loader): updates React component

8832e3e

docs(suggestion template): add a suggestion template

9b8e41a

feat(icons): added new icons

6f67737

fix(icons): updated icon names

71f58b1

fix(icons): menu rename

da4d059

fix(card-row): correct vertical align schema

6928b80

fix(grid-template): free up the fixed item vertical positioning contr…

5e33efd

…ol a bit

revert(revert whitespace): remove changes that reverted a revert

1b0efd8

monicawheeler force-pushed the develop branch from a58c5c3 to 1b0efd8 Compare August 25, 2021 16:24

monicawheeler merged commit d8e0d14 into main Aug 25, 2021

FuturaExtraBold reviewed Aug 25, 2021

View reviewed changes

monicawheeler changed the title ~~Next version bump (~v4.13.0)~~ Next version bump (~v4.12.0) Aug 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Next version bump (~v4.12.0) #738

Next version bump (~v4.12.0) #738

teenwolfblitzer commented Aug 20, 2021 •

edited by monicawheeler

teenwolfblitzer Aug 23, 2021

anechol left a comment

FuturaExtraBold left a comment

Next version bump (~v4.12.0) #738

Next version bump (~v4.12.0) #738

Conversation

teenwolfblitzer commented Aug 20, 2021 • edited by monicawheeler

teenwolfblitzer Aug 23, 2021

Choose a reason for hiding this comment

anechol left a comment

Choose a reason for hiding this comment

FuturaExtraBold left a comment

Choose a reason for hiding this comment

teenwolfblitzer commented Aug 20, 2021 •

edited by monicawheeler