Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Camel and fix compilation issues #1091

Merged
merged 3 commits into from
May 21, 2024
Merged

chore: Update Camel and fix compilation issues #1091

merged 3 commits into from
May 21, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented May 17, 2024

Context

Update camel to 4.6.0 and fix compilation errors

@lordrip lordrip requested a review from igarashitm May 17, 2024 16:26
@lordrip
Copy link
Member Author

lordrip commented May 17, 2024

@igarashitm , there's a test failing but I'm not sure how to approach it

[INFO] Results:
[INFO]
[ERROR] Errors: 
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelCatalogProcessorTest.<init>:54 ┬╗  Option 'variables' not found for processor 'org.apache.camel.model.SetVariablesDefinition'
[ERROR]   CamelYamlDslSchemaProcessorTest.testProcessSubSchema:51 NullPointer Cannot invoke "com.fasterxml.jackson.databind.JsonNode.asText()" because the return value of "com.fasterxml.jackson.databind.node.ObjectNode.get(String)" is null
[INFO]
[ERROR] Tests run: 34, Failures: 0, Errors: 17, Skipped: 0

@lordrip lordrip mentioned this pull request May 17, 2024
Closed
1 task
@igarashitm
fix: fix for camel 4.6 model changes
5224786 
- `setVariables` is added, need a little adjustment for schema/catalog comparison
- YAML DSL `streamCaching` option on RouteDefinition was aligned to `streamCache` which is used for XML/Java DSL
- `RegistryBeanDefinition` for YAML `beans` and `RouteTemplateBean` for Kamelet has been migrated to `BeanFactoryDefinition`
- `ErrorHandlerBuilderDeserializer` was migrated to `ErrorHandlerDeserializer`
@igarashitm
chore: adjustments in UI tests and e2e
35b7156
@lordrip lordrip marked this pull request as ready for review May 21, 2024 15:06
@lordrip lordrip merged commit 0825e12 into KaotoIO:main May 21, 2024
10 checks passed
@lordrip lordrip deleted the fix/camel-catalog branch May 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igarashitm igarashitm Awaiting requested review from igarashitm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lordrip @igarashitm