Skip to content

Commit

Permalink
Fix providers lint warnings & make 0.0.11 release (#25)
Browse files Browse the repository at this point in the history
Co-authored-by: maxim-konovalov <maksim.konovalov@vk.team>
  • Loading branch information
KaymeKaydex and maxim-konovalov committed May 13, 2024
1 parent 660a58f commit cb8c86a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
## Unreleased

## 0.0.11

BUG FIXES:

* Fix buckets discovery (it doesn't freeze now)

## 0.0.11

FEATURES:

* BucketStat has become a public method (#21)
* Add golang-ci logic

REFACTOR:

* WSL lint providers fix
* Lint refactor with spaces
* Split tests for shadow and not vshard module
* Update Makefile with cover & lint
Expand Down
14 changes: 7 additions & 7 deletions providers.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ func (e *EmptyLogger) Warn(_ context.Context, _ string) {}

type StdoutLogger struct{}

func (e *StdoutLogger) Info(ctx context.Context, msg string) {
func (e *StdoutLogger) Info(_ context.Context, msg string) {
log.Println(msg)
}
func (e *StdoutLogger) Debug(ctx context.Context, msg string) {
func (e *StdoutLogger) Debug(_ context.Context, msg string) {
log.Println(msg)
}
func (e *StdoutLogger) Error(ctx context.Context, msg string) {
func (e *StdoutLogger) Error(_ context.Context, msg string) {
log.Println(msg)
}
func (e *StdoutLogger) Warn(ctx context.Context, msg string) {
func (e *StdoutLogger) Warn(_ context.Context, msg string) {
log.Println(msg)
}

Expand All @@ -54,9 +54,9 @@ type MetricsProvider interface {
// you can embed this type and realize just some metrics
type EmptyMetrics struct{}

func (e *EmptyMetrics) CronDiscoveryEvent(ok bool, duration time.Duration, reason string) {}
func (e *EmptyMetrics) RetryOnCall(reason string) {}
func (e *EmptyMetrics) RequestDuration(duration time.Duration, ok bool, mapReduce bool) {}
func (e *EmptyMetrics) CronDiscoveryEvent(_ bool, _ time.Duration, _ string) {}
func (e *EmptyMetrics) RetryOnCall(_ string) {}
func (e *EmptyMetrics) RequestDuration(_ time.Duration, _ bool, _ bool) {}

// TopologyProvider is external module that can lookup current topology of cluster
// it might be etcd/config/consul or smth else
Expand Down

0 comments on commit cb8c86a

Please sign in to comment.