Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/faces: use pooler face instead pool struct; up coverage and init tests for BucketStat; add Stringer methods for rs info #21

Merged
merged 7 commits into from
May 13, 2024

Conversation

KaymeKaydex
Copy link
Owner

  • use face instead pool struct
  • add mocks and first test with mock for replicaset bucket stat
  • make bucket stat public method(there is no problem if user wanna use it)

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 16.20%. Comparing base (9e72b8c) to head (b2cf45c).

Files Patch % Lines
discovery.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   13.82%   16.20%   +2.38%     
==========================================
  Files           9        9              
  Lines         615      617       +2     
==========================================
+ Hits           85      100      +15     
+ Misses        525      511      -14     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaymeKaydex KaymeKaydex changed the title feature/faces feature/faces: use pooler face instead pool struct; up coverage and init tests for BucketStat May 13, 2024
@KaymeKaydex KaymeKaydex changed the title feature/faces: use pooler face instead pool struct; up coverage and init tests for BucketStat feature/faces: use pooler face instead pool struct; up coverage and init tests for BucketStat; add Stringer methods for logs May 13, 2024
@KaymeKaydex KaymeKaydex changed the title feature/faces: use pooler face instead pool struct; up coverage and init tests for BucketStat; add Stringer methods for logs feature/faces: use pooler face instead pool struct; up coverage and init tests for BucketStat; add Stringer methods for rs info May 13, 2024
@KaymeKaydex KaymeKaydex merged commit cb92282 into master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants