[fastlane-core] recommends to retry uploading when AltoolTransporterE…

…xecutor crashes (fastlane#21536)

* Force FastlanePty.spawn to return exit code if it ends up being nil for whatever reason

* Actually, let's implement the fix right where the problem occurs, and add a test

* Update fastlane_core/lib/fastlane_core/itunes_transporter.rb

Co-authored-by: Aaron Brager <getaaron@gmail.com>

* Remove unneeded nil catch given fastlane#21618

* Write more accurate test

---------

Co-authored-by: Aaron Brager <getaaron@gmail.com>

fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -215,6 +215,8 @@ class AltoolTransporterExecutor < TransporterExecutor
 
     private_constant :ERROR_REGEX
 
+    attr_reader :errors
+
     def execute(command, hide_output)
       if Helper.test?
         yield(nil) if block_given?
@@ -244,6 +246,7 @@ def execute(command, hide_output)
       end
 
       @errors << "The call to the altool completed with a non-zero exit status: #{exit_status}. This indicates a failure." unless exit_status.zero?
+      @errors << "-1 indicates altool exited abnormally; try retrying (see https://github.com/fastlane/fastlane/issues/21535)" if exit_status == -1
 
       unless @errors.empty? || @all_lines.empty?
         # Print the last lines that appear after the last error from the logs

fastlane_core/spec/itunes_transporter_spec.rb

@@ -1396,4 +1396,21 @@ def xcrun_download_command(provider_short_name = nil, jwt: nil)
       end
     end
   end
+
+  describe FastlaneCore::AltoolTransporterExecutor do
+    let(:upload_cmd) { "xcrun altool --upload-app --apiKey #{api_key[:key_id]} --apiIssuer #{api_key[:issuer_id]} -t macos -f /tmp/my.app.id.itmsp -k 100000" }
+    let(:instance) { described_class.new }
+    describe "#execute" do
+      it "logs specific info about altool crash if exit code is -1" do
+        # remove test behavior, we actually want FastlanePty.spawn to be called here
+        allow(FastlaneCore::Helper).to receive(:test?).and_return(false)
+        # force the nil return of FastlanePty.spawn
+        allow(FastlaneCore::FastlanePty).to receive(:spawn).and_return(-1)
+        expect(instance.execute(upload_cmd, false)).to eq(false)
+        expect(instance.errors).to include(
+          "-1 indicates altool exited abnormally; try retrying (see https://github.com/fastlane/fastlane/issues/21535)"
+        )
+      end
+    end
+  end
 end