Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update octokit monorepo (major) #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 1, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/plugin-retry 6.0.1 -> 7.1.1 age adoption passing confidence
@octokit/webhooks-methods ^4.1.0 -> ^5.1.0 age adoption passing confidence

Release Notes

octokit/plugin-retry.js (@​octokit/plugin-retry)

v7.1.1

Compare Source

Bug Fixes

v7.1.0

Compare Source

Features

v7.0.4

Compare Source

Bug Fixes

v7.0.3

Compare Source

Bug Fixes

v7.0.2

Compare Source

Bug Fixes

v7.0.1

Compare Source

Bug Fixes

v7.0.0

Compare Source

Features
BREAKING CHANGES
  • package is now ESM
octokit/webhooks-methods.js (@​octokit/webhooks-methods)

v5.1.0

Compare Source

Features

v5.0.0

Compare Source

Features
BREAKING CHANGES
  • output ESM instead of CommonJS
  • remove SHA1 support
  • The verify() and sign() methods no longer accept an options object

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Mar 1, 2024
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from 8afba6f to 56e1e9e Compare March 1, 2024 22:57
@Kesin11
Copy link
Owner

Kesin11 commented Mar 2, 2024

tsc error log

> @kesin[11](https://github.com/Kesin11/github_actions_otel_trace/actions/runs/8118169420/job/22191916052?pr=124#step:5:12)/github_actions_otel_trace@0.1.0 build
> tsc -b

Error: src/github.ts([13](https://github.com/Kesin11/github_actions_otel_trace/actions/runs/8118169420/job/22191916052?pr=124#step:5:14),40): error TS[23](https://github.com/Kesin11/github_actions_otel_trace/actions/runs/8118169420/job/22191916052?pr=124#step:5:24)45: Argument of type 'typeof retry' is not assignable to parameter of type 'OctokitPlugin'.
  Types of parameters 'octokit' and 'octokit' are incompatible.
    Type 'import("/home/runner/work/github_actions_otel_trace/github_actions_otel_trace/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/home/runner/work/github_actions_otel_trace/github_actions_otel_trace/packages/github_actions_otel_trace/node_modules/@octokit/core/dist-types/index").Octokit'.
      The types of 'hook.before' are incompatible between these types.
        Type '<Name extends keyof Hooks>(name: Name, beforeHook: BeforeHook<GetType<Hooks[Name], "Options", "O">>) => void' is not assignable to type '<Name extends keyof Hooks>(name: Name, beforeHook: BeforeHook<GetType<Hooks[Name], "Options">>) => void'.
          Types of parameters 'beforeHook' and 'beforeHook' are incompatible.
            Types of parameters 'options' and 'options' are incompatible.
              Type 'GetType<Hooks[Name], "Options", "O">' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                Type 'Hooks[Name][keyof Hooks[Name] & "Options"] | ("O" extends keyof Hooks[Name] ? Hooks[Name][keyof Hooks[Name] & "O"] : any)' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                  Type 'Hooks[Name][keyof Hooks[Name] & "Options"]' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                    Type 'Hooks[Name]["Options"]' is not assignable to type 'GetType<Hooks[Name], "Options">'.
npm ERR! Lifecycle script `build` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @kesin11/github_actions_otel_trace@0.1.0 
npm ERR!   at location: /home/runner/work/github_actions_otel_trace/github_actions_otel_trace/packages/github_actions_otel_trace 

> server@1.0.0 build
> tsc -b

Error: ../github_actions_otel_trace/src/github.ts(13,40): error TS2[34](https://github.com/Kesin11/github_actions_otel_trace/actions/runs/8118169420/job/22191916052?pr=124#step:5:35)5: Argument of type 'typeof retry' is not assignable to parameter of type 'OctokitPlugin'.
  Types of parameters 'octokit' and 'octokit' are incompatible.
    Type 'import("/home/runner/work/github_actions_otel_trace/github_actions_otel_trace/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/home/runner/work/github_actions_otel_trace/github_actions_otel_trace/packages/github_actions_otel_trace/node_modules/@octokit/core/dist-types/index").Octokit'.
      The types of 'hook.before' are incompatible between these types.
        Type '<Name extends keyof Hooks>(name: Name, beforeHook: BeforeHook<GetType<Hooks[Name], "Options", "O">>) => void' is not assignable to type '<Name extends keyof Hooks>(name: Name, beforeHook: BeforeHook<GetType<Hooks[Name], "Options">>) => void'.
          Types of parameters 'beforeHook' and 'beforeHook' are incompatible.
            Types of parameters 'options' and 'options' are incompatible.
              Type 'GetType<Hooks[Name], "Options", "O">' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                Type 'Hooks[Name][keyof Hooks[Name] & "Options"] | ("O" extends keyof Hooks[Name] ? Hooks[Name][keyof Hooks[Name] & "O"] : any)' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                  Type 'Hooks[Name][keyof Hooks[Name] & "Options"]' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                    Type 'Hooks[Name]["Options"]' is not assignable to type 'GetType<Hooks[Name], "Options">'.
npm ERR! Lifecycle script `build` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: server@1.0.0 
npm ERR!   at location: /home/runner/work/github_actions_otel_trace/github_actions_otel_trace/packages/server

@Kesin11
Copy link
Owner

Kesin11 commented Mar 2, 2024

The type incompatible error is probably caused by the fact that octokit/rest.js now depends on @octokit/core v5 while octokit/plugin-retry.js now depends on @octokit/core v6.
octokit/rest.js pull-request that update @octokit/core to v6 is still open. octokit/rest.js#411

More specifically, this is because the before-after-hook version was changed in the update from @octokit/core v5 to v6.
https://github.com/octokit/core.js/compare/v5.1.0... .v6.0.1

So, I will wait for an update to octokit/rest.js.

@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 3 times, most recently from 5c1fecb to d856d0a Compare March 8, 2024 19:41
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from d856d0a to b3ee29b Compare March 15, 2024 19:46
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 4 times, most recently from 603af13 to f4cf3a7 Compare April 7, 2024 23:06
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 2 times, most recently from c986209 to 9bb7544 Compare April 26, 2024 23:00
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from 9bb7544 to 186952d Compare May 10, 2024 18:51
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from 186952d to 65c3023 Compare May 11, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant