-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOCUSED: Fix low-contrast of line and dot in number-line component #1281
base: main
Are you sure you want to change the base?
Conversation
Size Change: +2.31 kB (+0.28%) Total Size: 842 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 69.18% 71.51% +2.32%
==========================================
Files 476 486 +10
Lines 101772 102648 +876
Branches 7226 11751 +4525
==========================================
+ Hits 70415 73404 +2989
+ Misses 31178 29244 -1934
+ Partials 179 0 -179
... and 165 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -472,25 +472,25 @@ class NumberLine extends React.Component<Props, State> { | |||
// it can't be interacted with. | |||
let fill; | |||
if (isOpen) { | |||
fill = KhanColors._BACKGROUND; | |||
fill = "transparent"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed based on a comment in the file defining KhanColors
that said it should be made transparent instead of using _BACKGROUND
Summary:
This fixes an issue where the line and point in the number-line widget were not meeting the WCAG standards for color contrast. The contrast should be at least 3:1, which is implemented here using WB color tokens.
Before fix:
After fix:
Issue: LEMS-252
Test plan:
yarn storybook