Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rm-input-number] 4 - Remove input-number editor and fix editor tests #433

Draft
wants to merge 1 commit into
base: rm-input-number.3
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

This is the fourth PR of deleting the input-number widget from Perseus. In this one we remove the input-number editor and update all related tests.

Note that this PR contains Flow and Jest failures. I am going to fix/resolve these issues over the next few PRs so that each one is smaller and easier to review. The entire stack will only be landed once everything has been fixed and tested.

Previous PRs in stack:

Issue: LC-616

Test plan:

yarn test editor_test.jsx traversal_test.jsx register-all-widgets-and-editors-for-testing_test.js

@jeremywiebe jeremywiebe self-assigned this Mar 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

⚠️ No Changeset found

Latest commit: 0fa3c88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (250685d) and published it to npm. You
can install it using the tag PR433.

Example:

yarn add @khanacademy/perseus@PR433

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Size Change: +117 B (0%)

Total Size: 652 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 114 kB +117 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 60.3 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 398 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant