-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles: Less file housecleaning #877
base: main
Are you sure you want to change the base?
Conversation
Size Change: -3 B (0%) Total Size: 834 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 59.43% 60.72% +1.28%
==========================================
Files 417 419 +2
Lines 99579 99596 +17
Branches 6053 8607 +2554
==========================================
+ Hits 59187 60478 +1291
+ Misses 40392 39118 -1274
... and 71 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -672,73 +671,4 @@ | |||
} | |||
} | |||
|
|||
/* Derived from the MIT-licensed zoom.js: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This chunk of styles was moved to zoom.less
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me! Thanks, @jeremywiebe !
A round of Less file cleanup. There were a bunch of unused variables and files. I figured out what was unused by running
yarn build --watch
and then starting to delete variables. Any time there was a varaible that was still in use, there would be an error like this[!] (plugin commonjs--resolver) Error: variable @gray95 is undefined
.Issue: --none--
Test plan:
yarn build
is successful (our builds process Less files into CSS and so if there's variable references that no longer exist, it will fail)